Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor housekeeping 2024121700 #709

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

vathpela
Copy link
Contributor

This fixes a header error with clang, and suppresses the clang compiler warnings when building compile_commands.json

Right now when doing test builds with clang, we wind up getting an error
from two different definitions of CLANG_PREREQ() in the headers.

It might be that we can just rip one of these out, but for now I'm just
making one of them conditional.

Signed-off-by: Peter Jones <[email protected]>
This make target doesn't actually use any of the objects built by the
compiler, so there's no concern about using an untested compiler or
anything like that.

It doesn't really need the warnings to show either, and they're
obnoxious, so this commit takes them out for that build target.

Signed-off-by: Peter Jones <[email protected]>
@vathpela vathpela force-pushed the minor-housekeeping-2024121700 branch 4 times, most recently from 9a93dff to 31fb30e Compare December 17, 2024 17:22
In some cases the -Werror / -Wfoo / -Wno-foo / -Wno-error=foo bits
aren't propagating in a way that clang is happy with, so we get errors
about unused variables and the like in Cryptlib and OpenSSL.

We're never going to fix those nits in this tree, so this patch tries
even harder to make the compiler ignore them, or at least not end the
build with a benign error.

Signed-off-by: Peter Jones <[email protected]>
I use compile_commands.json with vim all the time, so it's better if it
doesn't break.

This adds it to CI builds to try to ensure that better.

Signed-off-by: Peter Jones <[email protected]>
@vathpela vathpela force-pushed the minor-housekeeping-2024121700 branch from 31fb30e to 4e8145e Compare December 17, 2024 18:09
@vathpela vathpela merged commit fd7e16f into rhboot:main Dec 17, 2024
20 checks passed
@vathpela vathpela deleted the minor-housekeeping-2024121700 branch December 17, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants